Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add filter label parameter for functional tests #3566

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add filter label parameter for functional tests #3566

wants to merge 2 commits into from

Conversation

Davo911
Copy link
Contributor

@Davo911 Davo911 commented Dec 13, 2024

What this PR does / why we need it:
This change adds a label-filter parameter to the functional test script.

This allows users to specify a label filter via the CDI_LABEL_FILTER environment variable, enabling better test selection without relying on hardcoded labels in the test descriptions.
Discussed in #3565 and makes the introduced label usable.

Release note:

NONE

@Davo911
add parameter
f1bea69 
Signed-off-by: Thomas-David Griedel <[email protected]>
@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Dec 13, 2024
@kubevirt-bot
Copy link
Contributor

Hi @Davo911. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign akalenyu for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

akalenyu
akalenyu reviewed Dec 15, 2024
View reviewed changes
Copy link
Collaborator

@akalenyu akalenyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! just worried this could mess up the existing test set in the non destructive lane

hack/build/run-functional-tests.sh Show resolved Hide resolved
@akalenyu
Copy link
Collaborator

/test all

@akalenyu
Copy link
Collaborator

/test pull-containerized-data-importer-non-csi-hpp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akalenyu akalenyu akalenyu left review comments

@aglitke aglitke Awaiting requested review from aglitke

@arnongilboa arnongilboa Awaiting requested review from arnongilboa

Assignees
No one assigned
Labels
dco-signoff: yes Indicates the PR's author has DCO signed all their commits. release-note-none Denotes a PR that doesn't merit a release note. size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Davo911 @kubevirt-bot @akalenyu